Repository navigation
fix crash when using the on-screen numpad caused by improperly set prop - #26267
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
|
Merging since it fixes a blocker. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.59-0 🚀
|
|
@luacmartins I have reported similar bug earlier: Dev - Focus is not applied to amount field when clicking 'Request money' button. And it seems to be solved here. This is to request if I am eligible for reporting bonus? |
|
@Natnael-Guchima thanks for bringing this up. Sorry, I don't think the reporting bonus would apply in this case since it shared a root cause with the current bug we're fixing within the regression period. |
|
@luacmartins according to the guidelines if a report comes before a fixing PR, and if the reporter idenfies the fixing PR, it states that the reporter should be eligible for reporting bonus. And if a reporter is not eligible for a reporting a bug that is within the 7 day regression period, it seems that it would be hard to find a bug that is eligible for reporting bonus since most of the bugs are caught within the regression period. Can you please reconsider your decision? Thanks. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.60-0 🚀
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.60-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀
|
Details
This PR sets the ref prop properly for the BaseTextInputWithCurrencySymbol component.
Fixed Issues
$ #25578
PROPOSAL: #25578 (comment)
Tests
Offline tests
None.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
25578-fix-android-chrome.webm
Mobile Web - Safari
25578-fix-ios-safari.mp4
Desktop
iOS
25578-fix-ios-native.mp4
Android
25578-fix-android-native.webm